Remove check that only shows Service Level option on non-EU firmwares #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There looks to be an issue where the service level can be set to 1 in the EU firmware, without this option this can not be corrected.
|
Shouldn't this be fixed on evse fw? As there's no such thing as service
level in Europe, it was really confusing.
Le mer. 25 oct. 2023, 20:41, Glyn Hudson ***@***.***> a
écrit :
… Merged #15 <#15> into
master.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXKVP5DODAAV5WE2EDBITYBFMNNAVCNFSM6AAAAAA6MU4CIOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQG43TCMBYGIZDONA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Yes, but the EVSE firmware is not easily updatable so we have to do something for them. Maybe we can add something to the WiFi firmware to correct the issue but this is a quick fix for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There looks to be an issue where the service level can be set to 1 in the EU firmware, without this option this can not be corrected.